New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #13 #16

Merged
merged 2 commits into from Oct 24, 2017

Conversation

3 participants
@evanthomas
Contributor

evanthomas commented Oct 22, 2017

The JS renderer is broken because it is generating JS objects with null values which, in turn, cause plotly to choke. This change simply runs through io.circe.Printer to strip those fields out.

@alexarchambault

This comment has been minimized.

Show comment
Hide comment
@alexarchambault

alexarchambault Oct 23, 2017

Owner

Not sure why the CI isn't running here… :\ I'll try to test that locally.

Owner

alexarchambault commented Oct 23, 2017

Not sure why the CI isn't running here… :\ I'll try to test that locally.

@alexarchambault

This comment has been minimized.

Show comment
Hide comment
@alexarchambault

alexarchambault Oct 24, 2017

Owner

Tested locally, seems fine! Thanks!

Owner

alexarchambault commented Oct 24, 2017

Tested locally, seems fine! Thanks!

@alexarchambault alexarchambault merged commit 8149ddf into alexarchambault:master Oct 24, 2017

@alexarchambault

This comment has been minimized.

Show comment
Hide comment
@alexarchambault

alexarchambault Oct 24, 2017

Owner

0.3.3, with that, is out.

Owner

alexarchambault commented Oct 24, 2017

0.3.3, with that, is out.

@evan-wehi

This comment has been minimized.

Show comment
Hide comment
@evan-wehi

evan-wehi commented Oct 24, 2017

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment