New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the express server from the code to actually serve and respond on the port #43

Closed
PWKad opened this Issue Oct 2, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@PWKad
Contributor

PWKad commented Oct 2, 2018

Why?

Separating them out by concern (the routing and application vs the serving and responding on which port, etc...) allows changing how the application can be tested and makes it slightly easier to understand

(reposting from our conversation on Slack)

PWKad added a commit to PWKad/ln-service that referenced this issue Oct 3, 2018

@PWKad

This comment has been minimized.

Contributor

PWKad commented Oct 4, 2018

Did not work as easily as expected, closing for now.

@PWKad PWKad closed this Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment