Seperate out app and serving logic #51
Conversation
bin/www
Outdated
| @@ -0,0 +1,114 @@ | |||
| #!/usr/bin/env node | |||
There was a problem hiding this comment.
I basically took the default bin/www that express generates and moved the listening on ports stuff over as-is in to the file
There was a problem hiding this comment.
Can I still use nodemon on the server?
There was a problem hiding this comment.
Yes, I'll verify again but this is how I typically set up my start script -
"start": "npm install && nodemon ./bin/www",
To show that it should be the exact same way to run it with nodemon
There was a problem hiding this comment.
you need to chmod the www file?
There was a problem hiding this comment.
I don't that I know of
server.js
Outdated
| const unlockDelayMs = 1000; | ||
| const unlockerLnd = localLnd({is_unlocker: true}); | ||
|
|
||
| if (NODE_ENV !== 'production') { | ||
| walnut.check(require('./package')); | ||
| } | ||
|
|
||
| module.exports = app; |
There was a problem hiding this comment.
export the app. I'm testing now the effect of doing it this way on setting up the routes in the http tests, if you have any feedback on doing this different just lmk
There was a problem hiding this comment.
does this mean it would be possible to have both ways of running the server? the bin/www way and the original way as well?
There was a problem hiding this comment.
The logic that was there before is just moved in to the www file to be a node script that is run when actually serving the code.
By separating it out the app can be set up independently without actually turning on the web server and listening to the port, this allows libs like supertest to run it and test out the end points in an integration test without having it running and calling the api manually.
HTTP tests coming in a separate PR, wanted to put this up for discussion first.
There was a problem hiding this comment.
Better explanation -
There was a problem hiding this comment.
Maybe it would be nicer if running nodemon server.js still does the same thing it did before but its internals change to use an abstracted server that also is used in the www/bin and for testing?
There was a problem hiding this comment.
What about -
$ mv ./server.js ./app.js
$ mv ./bin/www /.server.js
Then the command wouldn't even change?
There was a problem hiding this comment.
Updated the PR to show what I mean
There was a problem hiding this comment.
I don't 100% understand the change but if you add a test I can mess around with things and try and make sure the test still passes
Fixes #43