Changed property definition to 'copy', removed explicit setter methods for inputBlock and outputBlock #23

Merged
merged 2 commits into from May 21, 2013

Conversation

Projects
None yet
3 participants
@coryalder
Contributor

coryalder commented Jul 12, 2012

Since the setter and getter methods -(void)setInputBlock: and -(void)setOutputBlock: are basically implementing the automatically generated 'copy' manually, as far as I can see there is no reason not to change the properties for inputBlock and outputBlock to "copy" (from "retain") and remove the manual setters.

The downsides: none I can see.
The upsides: two less warnings at compile time.

Re: issue #3 Warnings and Link Errors

@alexbw

This comment has been minimized.

Show comment Hide comment
@alexbw

alexbw Jul 12, 2012

Owner

Sounds good. Let's do this.

On Thursday, July 12, 2012 at 6:39 PM, Cory Alder wrote:

Since the setter and getter methods -(void)setInputBlock: and -(void)setOutputBlock: are basically implementing the automatically generated 'copy' manually, as far as I can see there is no reason not to change the properties for inputBlock and outputBlock to "copy" (from "retain") and remove the manual setters.

The downsides: none I can see.
The upsides: two less warnings at compile time.

Re: issue #3 Warnings and Link Errors

You can merge this Pull Request by running:

git pull https://github.com/coryalder/novocaine master

Or you can view, comment on it, or merge it online at:

#23

-- Commit Summary --

  • Removed input and output block setters (using 'copy' property instead).
  • Changed inputBlock and outputBlock properties from 'retain' to 'copy'

-- File Changes --

M Novocaine/Novocaine.h (4)
M Novocaine/Novocaine.m (17)

-- Patch Links --

https://github.com/alexbw/novocaine/pull/23.patch
https://github.com/alexbw/novocaine/pull/23.diff


Reply to this email directly or view it on GitHub:
#23

Owner

alexbw commented Jul 12, 2012

Sounds good. Let's do this.

On Thursday, July 12, 2012 at 6:39 PM, Cory Alder wrote:

Since the setter and getter methods -(void)setInputBlock: and -(void)setOutputBlock: are basically implementing the automatically generated 'copy' manually, as far as I can see there is no reason not to change the properties for inputBlock and outputBlock to "copy" (from "retain") and remove the manual setters.

The downsides: none I can see.
The upsides: two less warnings at compile time.

Re: issue #3 Warnings and Link Errors

You can merge this Pull Request by running:

git pull https://github.com/coryalder/novocaine master

Or you can view, comment on it, or merge it online at:

#23

-- Commit Summary --

  • Removed input and output block setters (using 'copy' property instead).
  • Changed inputBlock and outputBlock properties from 'retain' to 'copy'

-- File Changes --

M Novocaine/Novocaine.h (4)
M Novocaine/Novocaine.m (17)

-- Patch Links --

https://github.com/alexbw/novocaine/pull/23.patch
https://github.com/alexbw/novocaine/pull/23.diff


Reply to this email directly or view it on GitHub:
#23

@ndonald2

This comment has been minimized.

Show comment Hide comment
@ndonald2

ndonald2 May 21, 2013

Collaborator

@alexbw This has been sitting here for quite awhile and it's definitely a valid fix. In my first action as someone you recently made a maintainer, I'm gonna go ahead and merge this in.

Collaborator

ndonald2 commented May 21, 2013

@alexbw This has been sitting here for quite awhile and it's definitely a valid fix. In my first action as someone you recently made a maintainer, I'm gonna go ahead and merge this in.

ndonald2 pushed a commit that referenced this pull request May 21, 2013

Nick D Nick D
Merge pull request #23 from coryalder/master
Changed property definition to 'copy', removed explicit setter methods for inputBlock and outputBlock

@ndonald2 ndonald2 merged commit 9f21e3c into alexbw:master May 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment