Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename `Config` type #189

Closed
brson opened this Issue Jul 13, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@brson
Copy link
Contributor

brson commented Jul 13, 2017

This is not all that descriptive a name, though we're not sure what a better name is. I suggest Builder. If nothing better comes up, pick that and we'll bikeshed it on the PR.

cc @alexcrichton @sfackler @dtolnay @Kimundi @BurntSushi bikeshedding.

@brson brson referenced this issue Jul 13, 2017

Closed

Crate evaluation tracking issue #198

20 of 25 tasks complete
@opilar

This comment has been minimized.

Copy link
Contributor

opilar commented Jul 19, 2017

+1 for Builder

@dtolnay

This comment has been minimized.

Copy link

dtolnay commented Jul 31, 2017

I am not a fan of Builder because it makes me expect a build() method that gives me back some object that I used it to build.

Some alternatives to explore:

@alexcrichton

This comment has been minimized.

Copy link
Owner

alexcrichton commented Jul 31, 2017

Build sounds pretty reasonable to me, becuase that's what's happening here anyway!

laumann added a commit to laumann/gcc-rs that referenced this issue Aug 8, 2017

laumann added a commit to laumann/gcc-rs that referenced this issue Aug 8, 2017

laumann added a commit to laumann/gcc-rs that referenced this issue Aug 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.