Skip to content

/cc-rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Clone, Debug and Default for Config #200

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@opilar @alexcrichton
@opilar
Copy link
Contributor

opilar commented Jul 13, 2017

Resolves #175

@alexcrichton alexcrichton merged commit c44c3c2 into alexcrichton:master Jul 13, 2017
2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Owner

alexcrichton commented Jul 13, 2017

👍
@opilar

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

opilar commented Jul 13, 2017

@alexcrichton can I ask a question?
Config::default() is not the same as Config::new(). Maybe it more appropriate to make default method to call new as here. Some boolean fields of Config struct is true, but default implementation for bool returns false.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Owner

alexcrichton commented Jul 13, 2017

Oh oops good catch! Yeah let's have a manual implementation of Default that delegates to new

@opilar opilar referenced this pull request Jul 15, 2017

Merged

Implementation for Config::default #204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.