New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed compile to accept name of library and updated examples #212

Merged
merged 2 commits into from Jul 18, 2017

Conversation

2 participants
@AndyGauge
Contributor

AndyGauge commented Jul 18, 2017

Addresses #185

@@ -296,7 +296,7 @@ impl Config {
/// .file("src/foo.c")
/// .shared_flag(true)
/// .static_flag(true)
/// .compile("libfoo.so");

This comment has been minimized.

@AndyGauge

AndyGauge Jul 18, 2017

Contributor

Can you review this line. I'm really not sure if this is in scope. IDK how .so passes that assert!

@AndyGauge

AndyGauge Jul 18, 2017

Contributor

Can you review this line. I'm really not sure if this is in scope. IDK how .so passes that assert!

This comment has been minimized.

@alexcrichton

alexcrichton Jul 18, 2017

Owner

Nah yeah this is fine!

@alexcrichton

alexcrichton Jul 18, 2017

Owner

Nah yeah this is fine!

@alexcrichton alexcrichton merged commit 8b993f4 into alexcrichton:master Jul 18, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Jul 18, 2017

Owner

Thanks!

Owner

alexcrichton commented Jul 18, 2017

Thanks!

FaultyRAM added a commit to FaultyRAM/gcc-rs that referenced this pull request Aug 11, 2017

Fix non-delimited library names
These were accepted in alexcrichton#212, but never actually worked and weren't being tested. This fixes the logic errors that prevented the new style from working, and also updates the tests to use the new style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment