Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upChanged compile to accept name of library and updated examples #212
Conversation
AndyGauge
reviewed
Jul 18, 2017
| @@ -296,7 +296,7 @@ impl Config { | |||
| /// .file("src/foo.c") | |||
| /// .shared_flag(true) | |||
| /// .static_flag(true) | |||
| /// .compile("libfoo.so"); | |||
This comment has been minimized.
This comment has been minimized.
AndyGauge
Jul 18, 2017
Author
Contributor
Can you review this line. I'm really not sure if this is in scope. IDK how .so passes that assert!
This comment has been minimized.
This comment has been minimized.
alexcrichton
merged commit 8b993f4
into
alexcrichton:master
Jul 18, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
alexcrichton
referenced this pull request
Jul 18, 2017
Closed
Change `compile` to take just a bare name, not a full file name #185
AndyGauge
referenced this pull request
Jul 19, 2017
Merged
Preventing bug if liberace makes a library using new syntax #214
FaultyRAM
added a commit
to FaultyRAM/gcc-rs
that referenced
this pull request
Aug 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
AndyGauge commentedJul 18, 2017
Addresses #185