Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove `compile_library` #213
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks! In terms of coordination though could this avoid deleting it just yet? Instead can this delete all references and just slap a When a new major release comes out I can clean out the deprecated pieces. |
omh1280
force-pushed the
omh1280:remove_compile_library
branch
from
d7e65b4
to
a761285
Jul 18, 2017
This comment has been minimized.
This comment has been minimized.
|
Updated! Thanks Alex |
alexcrichton
merged commit 7b6f4a0
into
alexcrichton:master
Jul 18, 2017
omh1280
deleted the
omh1280:remove_compile_library
branch
Jul 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
omh1280 commentedJul 18, 2017
Fixes #188.
Pretty straightforward removal. I use the syntax introduced in #205 in the README.
Let me know if it needs work!