New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `compile_library` #213

Merged
merged 2 commits into from Jul 18, 2017

Conversation

2 participants
@omh1280
Contributor

omh1280 commented Jul 18, 2017

Fixes #188.

Pretty straightforward removal. I use the syntax introduced in #205 in the README.

Let me know if it needs work!

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Jul 18, 2017

Owner

Thanks! In terms of coordination though could this avoid deleting it just yet? Instead can this delete all references and just slap a #[deprecated] and #[doc(hidden)] on it?

When a new major release comes out I can clean out the deprecated pieces.

Owner

alexcrichton commented Jul 18, 2017

Thanks! In terms of coordination though could this avoid deleting it just yet? Instead can this delete all references and just slap a #[deprecated] and #[doc(hidden)] on it?

When a new major release comes out I can clean out the deprecated pieces.

@omh1280

This comment has been minimized.

Show comment
Hide comment
@omh1280

omh1280 Jul 18, 2017

Contributor

Updated! Thanks Alex

Contributor

omh1280 commented Jul 18, 2017

Updated! Thanks Alex

@alexcrichton alexcrichton merged commit 7b6f4a0 into alexcrichton:master Jul 18, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@omh1280 omh1280 deleted the omh1280:remove_compile_library branch Jul 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment