Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upClarify behavior of `expand` #221
Conversation
jehiggs
added some commits
Jul 21, 2017
alexcrichton
merged commit 88ac58e
into
alexcrichton:master
Jul 24, 2017
This comment has been minimized.
This comment has been minimized.
|
Looks good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jehiggs commentedJul 24, 2017
Resolves #187.
I wasn't too sure what this should do if there's no files in the config. Expanding no files seems like a strange thing to do, but it wasn't clear to me that attempting to do so should also be a panic condition.