Rename `Config` type to `Build`

[laumann]

From the discussion it seems that gcc::Build was the preferred name.

Fixes #189

[alexcrichton]

Thanks! Mind also leaving behind a temporary pub use Build as Config with a #[doc(hidden)] so we can land this in the 0.3 series?

[laumann]

Sure! Should there be a deprecation warning to alert users to change Config to Build?

[laumann]

If I do:

#[doc(hidden)]
#[deprecated(since="0.3.51", notes="gcc::Config has been renamed to gcc::Build")]
pub type Config = Build;

I get deprecation warnings, but that doesn't work with pub use Build as Config

@alexcrichton Which do you prefer?

[alexcrichton]

@laumann ah unfortunately I think they'll effectively be the same which is to say functionally equivalent and #[deprecated] likely ignored on both.

In any case though this looks great to me, thanks!

[laumann]

ah unfortunately I think they'll effectively be the same which is to say functionally equivalent and #[deprecated] likely ignored on both.

I tried using gcc::Config in gcc-test/build.rs and only with the type alias did I get a deprecation warning when running cargo test (not with pub use).

Like this:

$ pwd
/home/tj/rust/gcc-rs/gcc-test
$ cargo check
   Compiling gcc v0.3.51 (file:///home/tj/rust/gcc-rs)
   Compiling gcc-test v0.1.0 (file:///home/tj/rust/gcc-rs/gcc-test)
warning: use of deprecated item: gcc::Config has been renamed to gcc::Build
  --> build.rs:12:5
   |
12 |     gcc::Config::new()
   |     ^^^^^^^^^^^^^^^^
   |
   = note: #[warn(deprecated)] on by default
    Finished dev [unoptimized + debuginfo] target(s) in 2.19 secs

But I don't know if there is anything special about gcc-test...

[alexcrichton]

Oh hey! I guess some bugs in rustc have gotten fixed since I last looked!

[laumann]

Always a nice surprise :-) But should deprecation on pub use Foo as Bar also generate a warning?

[alexcrichton]

Last I checked it didn't, but maybe it's changed!