Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor the deflate, gz and zlib modules & rename types #120
Conversation
This comment has been minimized.
This comment has been minimized.
|
I can see in the travis log that I forgot to cleanup the imports when different features are used. On it. |
This comment has been minimized.
This comment has been minimized.
|
Thanks so much for this! And wow that's quite the diff :) I'll poke around with this and probably merge promptly after! |
alexcrichton
merged commit e8a11e7
into
alexcrichton:master
Aug 30, 2017
alexcrichton
referenced this pull request
Aug 30, 2017
Closed
Rename internal types to match the public types #75
sbstp
deleted the
sbstp:refactor
branch
Aug 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sbstp commentedAug 28, 2017
I've re-factored the modules and types according to what was suggested in #75. Using
pub(crate)in a few places, I was able to avoid having to create multiple layers of modules. Here's a summary of the changes:deflate.rs,gz.rsandzlib.rsinto multiple files. Each module has amod.rs,bufread.rs,read.rsandwrite.rs.EncoderWriterbecomeswrite::(Deflate|Gz|Zlib)Encoder.DecoderReaderbecomesread::(Deflate|Gz|Zlib)Decoder. This was done for all the combinations.*Bufstructs are moved to their respectivebufreadsubmodule.*Readerstructs are moved to their respectivereadsubmodule.*Writerstructs are moved to their respectivewritesubmodule.pub(crates)here and there to keep the API unchanged.mod.rs.