Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDocumentation - Mention rust backend & update miniz and flate info #130
Conversation
This comment has been minimized.
This comment has been minimized.
|
Also, as miniz_oxide uses |
This comment has been minimized.
This comment has been minimized.
|
Nah I think it's ok to not worry too much about the version requirements here, this otherwise looks great to me, thanks! |
alexcrichton
merged commit 434490f
into
alexcrichton:master
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
oyvindln commentedOct 23, 2017
•
edited
Note that there is now a rust back-end. (Granted a version with it hasn't been published yet so I don't know if this should be changed until that's ready.)
Point the miniz link to the new github page instead of the removed google code one.
Mention that the flate library is no longer part of the rust compiler, and fix the link so it doesn't point to the wrong library.
The libflate library on crates.io is a different library so I removed the lib prefix in the documentation here to avoid confusion.
Not sure if a link to flate is really needed but I did a simple replacement for now.