Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pulldown diff #133

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Copy link
Contributor

GuillaumeGomez commented Nov 8, 2017

For the other output differences such as:

WARNING: rendering difference in `A DEFLATE-based stream compression/decompression library`
   --> src/lib.rs:1:0
    /html[0]/body[1]/p[4] Attributes differ in `a`: expected: `{"href": "bufread/index.html"}`, found: `{"href": "https://doc.rust-lang.org/std/io/trait.BufRead.html"}`

It's because in the old rustdoc markdown renderer, [read] == [Read]. So it's actually a good thing to have them.

EDIT: Ah, my bad. It's still an issue but a different one. Will be fixed in rustdoc so no need to change this.

EDIT of EDIT: The commonmark spec says:

As noted in the section on Links, matching of labels is case-insensitive (see matches).

You can see it here.

So I fixed them as well.

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:master branch from f2c98d6 to 9d736f7 Nov 8, 2017

@alexcrichton alexcrichton merged commit 945b134 into alexcrichton:master Nov 9, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.