Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix pulldown diff #133
Conversation
GuillaumeGomez
force-pushed the
GuillaumeGomez:master
branch
from
f2c98d6
to
9d736f7
Nov 8, 2017
alexcrichton
merged commit 945b134
into
alexcrichton:master
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
GuillaumeGomez commentedNov 8, 2017
•
edited
For the other output differences such as:
It's because in the old rustdoc markdown renderer,
[read] == [Read]. So it's actually a good thing to have them.EDIT: Ah, my bad. It's still an issue but a different one. Will be fixed in rustdoc so no need to change this.
EDIT of EDIT: The commonmark spec says:
You can see it here.
So I fixed them as well.