Bump minimum Rust version to 1.30 to use stable macro :vis matcher #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only Rust 1.21 job failed, which was expected per above; not sure how best to proceed with this. |
|
Looks good to me! I think I'd actually go ahead and bump this to 1.0, so want to push that up and bump the minimum Travis version? |
|
Sure! I’ll do that later today.
…On Mon, 25 Feb 2019 at 16:09, Alex Crichton ***@***.***> wrote:
Looks good to me! I think I'd actually go ahead and bump this to 1.0, so
want to push that up and bump the minimum Travis version?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC8y3RSAxTGM-FT4Q7XtvRax3n6ppZI4ks5vQ_zBgaJpZM4bOxWL>
.
|
|
@alexcrichton pushed the bump commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9.
Closes #5.
The
macro_vis_matcherfeature has been stabilized in 1.30 so there's no need to use a separatenightlyfeature flag for that.This technically bumps the minimum required
rustcversion to 1.30 so I'm not sure how we should proceed - we could either bump it to 0.2 so that people can opt-in into bumping it or rename the existing feature flag torust-1.30or similar and add themacro_vis_matcherto the linted against bare#[allow_internal_unstable].I tested the lint fix using
cargo check --all-featureswith a recent nightly compiler, @alexcrichton please let me know if I missed something!