Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests explain why they are failing #134

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@FauxFaux
Copy link
Contributor

commented Oct 7, 2019

The tests assert! a feature of the local ssh daemon which is disabled by default, at least from Ubuntu 18.04. Make the assertion error explain the problem, and hint how to fix it.

@wez

This comment has been minimized.

Copy link
Collaborator

commented Oct 9, 2019

Thanks for this!

@wez wez merged commit 172e8f1 into alexcrichton:master Oct 9, 2019
6 checks passed
6 checks passed
build (windows-2016, x86_64-pc-windows-msvc)
Details
build (macos-10.14)
Details
build (windows-2016, i686-pc-windows-msvc)
Details
build (windows-2019, x86_64-pc-windows-msvc)
Details
build (windows-2019, i686-pc-windows-msvc)
Details
Travis CI - Pull Request Build Passed
Details
@FauxFaux FauxFaux deleted the FauxFaux:tests-explain branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.