Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the test added by #349 with a bench #351

Merged
merged 1 commit into from Oct 29, 2019

Conversation

@est31
Copy link
Contributor

est31 commented Oct 28, 2019

CI environments can be noisy and while the test worked great
locally on my machine, it didn't on the CI environment.
This replaces the test with a (manually tracked) benchmark.
As per #349 (comment)

CI environments can be noisy and while the test worked great
locally on my machine, it didn't on the CI environment.
This replaces the test with a (manually tracked) benchmark.
As per #349 (comment)
@alexcrichton alexcrichton merged commit 4673cfd into alexcrichton:master Oct 29, 2019
5 checks passed
5 checks passed
Test (stable)
Details
Test (beta)
Details
Test (nightly)
Details
Rustfmt
Details
Publish Documentation
Details
@alexcrichton

This comment has been minimized.

Copy link
Owner

alexcrichton commented Oct 29, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.