From f17efd2eec01dfffcbe5190c263d826943d8d5a9 Mon Sep 17 00:00:00 2001 From: Alex Boxall Date: Tue, 7 Nov 2023 16:39:08 +1100 Subject: [PATCH] Changed are now formatted correctly --- core/play/src/main/java/play/mvc/Http.java | 14 ++++++----- .../java/play/mvc/SanitizedFilenameTest.java | 24 ++++++++++++------- 2 files changed, 24 insertions(+), 14 deletions(-) diff --git a/core/play/src/main/java/play/mvc/Http.java b/core/play/src/main/java/play/mvc/Http.java index 4ba05422cef..852fa19af54 100644 --- a/core/play/src/main/java/play/mvc/Http.java +++ b/core/play/src/main/java/play/mvc/Http.java @@ -15,9 +15,9 @@ import java.net.URLEncoder; import java.nio.charset.Charset; import java.nio.charset.StandardCharsets; +import java.nio.file.InvalidPathException; import java.nio.file.Path; import java.nio.file.Paths; -import java.nio.file.InvalidPathException; import java.security.cert.X509Certificate; import java.time.Duration; import java.util.*; @@ -1502,7 +1502,9 @@ public String getKey() { return key; } - /** @return the sanitized version of the file name (i.e. only the filename, no path components) */ + /** + * @return the sanitized version of the file name (i.e. only the filename, no path components) + */ public String getSanitizedFilename() { try { // Will throw InvalidPathException on invalid filepaths @@ -1516,13 +1518,13 @@ public String getSanitizedFilename() { } catch (InvalidPathException e) { throw new RuntimeException( - "Unable to sanitize the filename given to MultipartFormData.FilePart: \"" - + e.getInput() - + "\""); + "Unable to sanitize the filename given to MultipartFormData.FilePart: \"" + + e.getInput() + + "\""); } } - /** + /** * @deprecated Use {@link #getSanitizedFilename()} instead. * @return the raw file name */ diff --git a/core/play/src/test/java/play/mvc/SanitizedFilenameTest.java b/core/play/src/test/java/play/mvc/SanitizedFilenameTest.java index 3c46bec9c05..0cac31ce137 100644 --- a/core/play/src/test/java/play/mvc/SanitizedFilenameTest.java +++ b/core/play/src/test/java/play/mvc/SanitizedFilenameTest.java @@ -12,43 +12,50 @@ public class SanitizedFilenameTest { @Test public void sanitizeSingleComponent() { - MultipartFormData.FilePart p = new MultipartFormData.FilePart(null, "abc", null, null); + MultipartFormData.FilePart p = + new MultipartFormData.FilePart(null, "abc", null, null); assertEquals("abc", p.getSanitizedFilename()); } @Test public void sanitizeMultipleComponents() { - MultipartFormData.FilePart p = new MultipartFormData.FilePart(null, "abc/def/xyz", null, null); + MultipartFormData.FilePart p = + new MultipartFormData.FilePart(null, "abc/def/xyz", null, null); assertEquals("xyz", p.getSanitizedFilename()); } @Test public void sanitizeWithTrailingDots() { - MultipartFormData.FilePart p = new MultipartFormData.FilePart(null, "a/b/c/././", null, null); + MultipartFormData.FilePart p = + new MultipartFormData.FilePart(null, "a/b/c/././", null, null); assertEquals("c", p.getSanitizedFilename()); } @Test public void sanitizeWithLeadingDoubleDots() { - MultipartFormData.FilePart p = new MultipartFormData.FilePart(null, "../../../a", null, null); + MultipartFormData.FilePart p = + new MultipartFormData.FilePart(null, "../../../a", null, null); assertEquals("a", p.getSanitizedFilename()); } @Test public void sanitizeWithNameAfterDoubleDots() { - MultipartFormData.FilePart p = new MultipartFormData.FilePart(null, "../../../a/../b", null, null); + MultipartFormData.FilePart p = + new MultipartFormData.FilePart(null, "../../../a/../b", null, null); assertEquals("b", p.getSanitizedFilename()); } @Test public void sanitizeWithTrailingDoubleDots() { - MultipartFormData.FilePart p = new MultipartFormData.FilePart(null, "a/b/c/../..", null, null); + MultipartFormData.FilePart p = + new MultipartFormData.FilePart(null, "a/b/c/../..", null, null); assertEquals("a", p.getSanitizedFilename()); } @Test public void sanitizeWithRedundantSlashesAndDots() { - MultipartFormData.FilePart p = new MultipartFormData.FilePart(null, "///a//b/c/.././d/././/", null, null); + MultipartFormData.FilePart p = + new MultipartFormData.FilePart(null, "///a//b/c/.././d/././/", null, null); assertEquals("d", p.getSanitizedFilename()); } @@ -69,7 +76,8 @@ public void sanitizeThrowsOnDoubleDots() { @Test(expected = RuntimeException.class) public void sanitizeThrowsPastRoot() { - (new MultipartFormData.FilePart(null, "a/b/../../..", null, null)).getSanitizedFilename(); + (new MultipartFormData.FilePart(null, "a/b/../../..", null, null)) + .getSanitizedFilename(); } @Test(expected = RuntimeException.class)