New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace in secret creation #107

Merged
merged 1 commit into from Jan 7, 2019

Conversation

2 participants
@martindekov
Copy link
Contributor

martindekov commented Jan 7, 2019

Adding namespace when creating the secret since
the command was invalid and misleading

Signed-off-by: Martin Dekov (VMware) mdekov@vmware.com

kubectl command which creates secrets for derek was invalid (the namespace was missing)

Description

Adding default openfaas-fn namespace to the kubectl commands which created the two secrets

Motivation and Context

  • I have raised an issue to propose this change (required)

Didn't raise an issue due to the simplicity of the change

How Has This Been Tested?

N.A.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Add namespace in secret creation
Adding namespace when creating the secret since
the command was invalid and misleading

Signed-off-by: Martin Dekov (VMware) <mdekov@vmware.com>
@alexellis
Copy link
Owner

alexellis left a comment

Thank you!

@martindekov

This comment has been minimized.

Copy link
Contributor

martindekov commented Jan 7, 2019

Of course !

@alexellis alexellis merged commit 29e67e5 into alexellis:master Jan 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment