Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added my GitHub user name per the Get Derek instructions. #122

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
2 participants
@colin-mccarthy
Copy link
Contributor

colin-mccarthy commented Mar 7, 2019

Signed-off-by: colin-mccarthy <colin@colin.mccarthy80501@gmail.com>

Description

I have added my GitHub user name per the Get Derek instructions. I am excited to use Derek on my
repo.

Motivation and Context

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I've read the CONTRIBUTION guide
  • [x ] I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@derek derek bot added the new-contributor label Mar 7, 2019

@alexellis

This comment has been minimized.

Copy link
Owner

alexellis commented Mar 7, 2019

Hi Colin, your sign-on email is invalid. Please can you fix it?

Alex

@alexellis

This comment has been minimized.

Copy link
Owner

alexellis commented Mar 8, 2019

Please run:

git config --global user.name "Colin McCarthy"
git config --global user.email "colin.mccarthy80501@gmail.com"

git commit -s --amend --reset-author
git push origin master --force
Added my GitHub user name per the Get Derek instructions.
Signed-off-by: Colin McCarthy <colin.mccarthy80501@gmail.com>
@colin-mccarthy

This comment has been minimized.

Copy link
Contributor Author

colin-mccarthy commented Mar 12, 2019

Okay, I have fixed it. Thanks for the help!

@alexellis
Copy link
Owner

alexellis left a comment

LGTM

@alexellis alexellis merged commit e93e317 into alexellis:master Mar 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexellis

This comment has been minimized.

Copy link
Owner

alexellis commented Mar 13, 2019

Merged. Please see the readme on how to proceed and let me know if you run into any issues. Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.