Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows distributions in Makefile #32

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@rleungx
Copy link
Contributor

rleungx commented Feb 27, 2019

Description

The PR adds one more distribution: windows-amd64. Closes #23.

How Has This Been Tested?

Manually test on my Windows

How are existing users impacted? What migration steps/scripts do we need?

No.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
@alexellis

This comment has been minimized.

Copy link
Owner

alexellis commented Feb 27, 2019

Thanks for the PR.

Generally I wouldn't consider i386 worth the baggage and would go straight for windows-amd64 only named: inlets.exe

What are your thoughts?

@rleungx

This comment has been minimized.

Copy link
Contributor Author

rleungx commented Feb 28, 2019

Ok. BTW, do you want to separate these distributions into different targets?

@alexellis

This comment has been minimized.

Copy link
Owner

alexellis commented Mar 2, 2019

Hi I would like to see the following:

  • only inlets.exe with no explicit architecture set
  • Dockerfile updated (if applicable)
  • .travis.yml updated (if applicable) - it means we add the binary directly to the release after a build
  • Anything else updated where we create or package a binary
  • README updated to say Windows support available, but experimental

Alex

@alexellis
Copy link
Owner

alexellis left a comment

See comments

rleungx added some commits Feb 27, 2019

add windows dist in Makefile
Signed-off-by: Ryan Leung <rleungx@gmail.com>
address comments
Signed-off-by: Ryan Leung <rleungx@gmail.com>

@rleungx rleungx force-pushed the rleungx:windows-binary branch from 42a6c31 to e5cb82e Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.