Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce SHA hashes of each binary #45

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
2 participants
@kenfdev
Copy link
Contributor

kenfdev commented Mar 12, 2019

Description

This approacth is the same as openfaas/faas-cli.
Also updated travis to be picked up on the releases page.

Closes #44

Signed-off-by: Ken Fukuyama kenfdev@gmail.com

How Has This Been Tested?

$ ./ci/hashgen.sh 

Results:

$ ll bin
total 57072
-rwxr-xr-x  1 ken.fukuyama  staff   7.2M Mar 12 18:03 inlets
-rwxr-xr-x  1 ken.fukuyama  staff   6.7M Mar 12 18:04 inlets-arm64
-rw-r--r--  1 ken.fukuyama  staff    83B Mar 12 18:04 inlets-arm64.sha256
-rwxr-xr-x  1 ken.fukuyama  staff   6.1M Mar 12 18:03 inlets-armhf
-rw-r--r--  1 ken.fukuyama  staff    83B Mar 12 18:04 inlets-armhf.sha256
-rwxr-xr-x  1 ken.fukuyama  staff   7.9M Mar 12 18:03 inlets-darwin
-rw-r--r--  1 ken.fukuyama  staff    84B Mar 12 18:04 inlets-darwin.sha256
-rw-r--r--  1 ken.fukuyama  staff    77B Mar 12 18:04 inlets.sha256

How are existing users impacted? What migration steps/scripts do we need?

None.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests
Produce SHA hashes of each binary
This approacth is the same as openfaas/faas-cli.
Also updated travis to be picked up on the releases page.

Signed-off-by: Ken Fukuyama <kenfdev@gmail.com>

@derek derek bot added the new-contributor label Mar 12, 2019

skip_cleanup: true
on:
tags: true

This comment has been minimized.

@kenfdev

kenfdev Mar 12, 2019

Author Contributor

Looks like there was an extra line so delete it.

@alexellis

This comment has been minimized.

Copy link
Owner

alexellis commented Mar 12, 2019

I don't know if we check this value in get.sh, but if we don't then that should be a follow-up issue we can log and complete after this PR.

@alexellis
Copy link
Owner

alexellis left a comment

LGTM

@alexellis alexellis merged commit 36b0f6c into alexellis:master Mar 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexellis

This comment has been minimized.

Copy link
Owner

alexellis commented Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.