Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial ping/pong attempt #47

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
1 participant
@alexellis
Copy link
Owner

alexellis commented Mar 12, 2019

Description

Attempting to resolve #42 by sending continual ping from each
client to keep connection alive.

Signed-off-by: Alex Ellis alexellis2@gmail.com

How Has This Been Tested?

By running a client / server and monitoring output.

go build && ./inlets client --remote=localhost:80 --upstream=http://192.168.0.35:8080
2019/03/12 13:18:02 Upstream:  => http://192.168.0.35:8080
2019/03/12 13:18:02 connecting to ws://localhost:80/tunnel with ping=10s
2019/03/12 13:18:02 Ping duration: 10.000000s
2019/03/12 13:18:02 Connected to websocket: [::1]:57520
2019/03/12 13:18:02 Writing pings
2019/03/12 13:18:11 Ping sent
2019/03/12 13:18:11 PongHandler. Extend deadline.

The new flag --ping is also working with the default and override:

go build && ./inlets client --remote=localhost:80 --upstream=http://192.168.0.35:8080 --p
ing 1m
2019/03/12 13:18:20 Upstream:  => http://192.168.0.35:8080
2019/03/12 13:18:20 connecting to ws://localhost:80/tunnel with ping=1m0s

How are existing users impacted? What migration steps/scripts do we need?

Upgrading would be helpful to prevent timeouts

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests
Initial ping/pong attempt
Attempting to resolve #42 by sending continual ping from each
client to keep connection alive.

Signed-off-by: Alex Ellis <alexellis2@gmail.com>

@alexellis alexellis merged commit 73ad7c7 into master Mar 12, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexellis alexellis deleted the pingping branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.