Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a note about a k3s issue wrt iptables #92

Merged
merged 1 commit into from Nov 10, 2019

Conversation

@e-minguez
Copy link
Contributor

e-minguez commented Nov 7, 2019

Signed-off-by: Eduardo Minguez e.minguez@gmail.com

Description

Related to #89

Motivation and Context

Warn users to a possible issue wrt network not working.

  • I have raised an issue to propose this change

How Has This Been Tested?

Deployed k3s in Debian Buster and facing the issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

None of those.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@derek derek bot added the new-contributor label Nov 7, 2019
Copy link
Owner

alexellis left a comment

Added a comment. I think this could go in the appendix too.

README.md Outdated Show resolved Hide resolved
@e-minguez e-minguez force-pushed the e-minguez:iptables-nft_note branch from 9d29153 to 26574e1 Nov 8, 2019
@e-minguez

This comment has been minimized.

Copy link
Contributor Author

e-minguez commented Nov 8, 2019

Added a comment. I think this could go in the appendix too.

There is no appendix AFAIK. I've added the Debian Buster clarification.

@alexellis

This comment has been minimized.

Copy link
Owner

alexellis commented Nov 8, 2019

Let's create an appendix right at the bottom of the file

Signed-off-by: Eduardo Minguez <e.minguez@gmail.com>
@e-minguez e-minguez force-pushed the e-minguez:iptables-nft_note branch from 26574e1 to 2b6b712 Nov 8, 2019
@e-minguez

This comment has been minimized.

Copy link
Contributor Author

e-minguez commented Nov 8, 2019

Let's create an appendix right at the bottom of the file

Done

Copy link
Owner

alexellis left a comment

Approved, thank you

@alexellis alexellis merged commit 1670103 into alexellis:master Nov 10, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@e-minguez

This comment has been minimized.

Copy link
Contributor Author

e-minguez commented Nov 10, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.