Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put name of environment variable in error message #166

Merged
merged 1 commit into from Oct 1, 2021
Merged

Conversation

alexflint
Copy link
Owner

@alexflint alexflint commented Oct 1, 2021

Fixes #165

This pull request adds the name of the relevant environment variable to error messages

NEW:
error: --foo is required (or environment variable FOO)

OLD:
error: --foo is required

If no environment variable is associated with an argument then nothing is changed in the error message.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2021

Codecov Report

Merging #166 (b47d6e3) into master (a4afd6a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #166   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          679       682    +3     
=========================================
+ Hits           679       682    +3     
Impacted Files Coverage Δ
parse.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4afd6a...b47d6e3. Read the comment docs.

@alexflint alexflint merged commit bf32f08 into master Oct 1, 2021
6 checks passed
@alexflint alexflint deleted the env-in-error branch October 1, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include env name in missing arg error
2 participants