Change recommended configuration to use plugin-specific parser rather than changing global parser #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r` is only used for `import` plugin rather than globally Presumably this is being used while people convert over to TypesScript, so scoping it to the individual plugin settings can prevent unrelated issues from popping up. We noticed some additional errors when changing the global parser, so this was the fix that worked in our case and follows the structure from the`eslint-plugin-import` docs https://github.com/benmosher/eslint-plugin-import#importparsers
bradzacher
approved these changes
Jan 9, 2019
|
Thank you for taking time to submit the PR! |
JounQin
added a commit
that referenced
this pull request
Sep 30, 2019
JounQin
added a commit
that referenced
this pull request
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed some unrelated errors when changing the global parser, so this was the fix that worked in our case and follows the structure from the
eslint-plugin-importdocs to change the parser forimportand restrict it to.tsand.tsxfiles.https://github.com/benmosher/eslint-plugin-import#importparsers