New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to click on a tag in the list of suggested tags to add it #2

Closed
jasondavis opened this Issue Dec 30, 2011 · 11 comments

Comments

Projects
None yet
4 participants
@jasondavis

jasondavis commented Dec 30, 2011

It would be nice to be able to Click on a tag once it is in the suggestion list

@ghost ghost assigned alexgorbatchev Jan 10, 2012

@nevf

This comment has been minimized.

Show comment
Hide comment
@nevf

nevf Jan 12, 2012

I am very surprised that clicking on an item in the suggestion list doesn't select it. This seems like the most basic of desired behaviour.

nevf commented Jan 12, 2012

I am very surprised that clicking on an item in the suggestion list doesn't select it. This seems like the most basic of desired behaviour.

@alexgorbatchev

This comment has been minimized.

Show comment
Hide comment
@alexgorbatchev

alexgorbatchev Jan 12, 2012

Owner

I agree, seems that I have overlooked this one.

Owner

alexgorbatchev commented Jan 12, 2012

I agree, seems that I have overlooked this one.

@nevf

This comment has been minimized.

Show comment
Hide comment
@nevf

nevf Jan 12, 2012

Any idea when you'll implement mouse click selection?

nevf commented Jan 12, 2012

Any idea when you'll implement mouse click selection?

@jasondavis

This comment has been minimized.

Show comment
Hide comment
@jasondavis

jasondavis Jan 12, 2012

jquery-textext is really an amazing project you got here, I mean I would rate it with the tagging ability of Stackoverflow and Facebook on the feature side of it, the only thing missing for me is the click ability, thanks for sharing your work with the world

jasondavis commented Jan 12, 2012

jquery-textext is really an amazing project you got here, I mean I would rate it with the tagging ability of Stackoverflow and Facebook on the feature side of it, the only thing missing for me is the click ability, thanks for sharing your work with the world

@alexgorbatchev

This comment has been minimized.

Show comment
Hide comment
@alexgorbatchev

alexgorbatchev Jan 12, 2012

Owner

@jasondavis thnx!

Not sure when exactly I'd be able to get to it. It would be awesome if you guys could take a look at it :)

Owner

alexgorbatchev commented Jan 12, 2012

@jasondavis thnx!

Not sure when exactly I'd be able to get to it. It would be awesome if you guys could take a look at it :)

@jasondavis

This comment has been minimized.

Show comment
Hide comment
@jasondavis

jasondavis Jan 14, 2012

I would love to contribute but I am more of a backend coder, I am not currently skilled enough with Javascript. I did take a look at the code though just to get an idea, and in Autocomplete plugin I found this

p.onClick = function(e)
{
    var self   = this,
        target = $(e.target)
        ;

    if(target.is(CSS_DOT_SUGGESTION))
        self.selectFromDropdown();
};

I would imagine that is for doing what this question was about but since it does not do it, maybe this is for a different click event?

jasondavis commented Jan 14, 2012

I would love to contribute but I am more of a backend coder, I am not currently skilled enough with Javascript. I did take a look at the code though just to get an idea, and in Autocomplete plugin I found this

p.onClick = function(e)
{
    var self   = this,
        target = $(e.target)
        ;

    if(target.is(CSS_DOT_SUGGESTION))
        self.selectFromDropdown();
};

I would imagine that is for doing what this question was about but since it does not do it, maybe this is for a different click event?

@jasondavis

This comment has been minimized.

Show comment
Hide comment
@jasondavis

jasondavis Jan 14, 2012

An update, I have found how out more information.

Here is an image that is more to the point of the problem... You have to click in the area highlighted with red for it to work as expected. So if you click anywhere outside of that red box it will not work, including on the actual text/name of the tag

click area

The ideal solution would allow you to click anywhere in the GREEN highlighted section to add that tag to the input box.
click area

If you watch this 2 minute video you can see, I am on Windows 7 with Chrome http://screencastle.com/watch/00ca12cc4d3e10de867b8404007f85a4

jasondavis commented Jan 14, 2012

An update, I have found how out more information.

Here is an image that is more to the point of the problem... You have to click in the area highlighted with red for it to work as expected. So if you click anywhere outside of that red box it will not work, including on the actual text/name of the tag

click area

The ideal solution would allow you to click anywhere in the GREEN highlighted section to add that tag to the input box.
click area

If you watch this 2 minute video you can see, I am on Windows 7 with Chrome http://screencastle.com/watch/00ca12cc4d3e10de867b8404007f85a4

adamayres added a commit to adamayres/jquery-textext that referenced this issue Jan 16, 2012

Fixes #2 #4 #5 - Capture mousedown event in autocomplete used by the …
…blur event to determine if it was triggered by a scroll click or an item selection, in which case we set focus back to the input instead of closing the autocomplete. Added a click listener to the document body that triggers the autocomplete to close when the click is not within the textext wrap element.

unamashana added a commit to unamashana/jquery-textext that referenced this issue Jan 31, 2012

Fixes #2 #4 #5 - Capture mousedown event in autocomplete used by the …
…blur event to determine if it was triggered by a scroll click or an item selection, in which case we set focus back to the input instead of closing the autocomplete. Added a click listener to the document body that triggers the autocomplete to close when the click is not within the textext wrap element.
@martinffx

This comment has been minimized.

Show comment
Hide comment
@martinffx

martinffx Feb 16, 2012

Any chance of merging one of these fixes into the main project

martinffx commented Feb 16, 2012

Any chance of merging one of these fixes into the main project

@alexgorbatchev

This comment has been minimized.

Show comment
Hide comment
@alexgorbatchev

alexgorbatchev Feb 17, 2012

Owner

Will merge it this weekend. Sorry about delay on this.

Owner

alexgorbatchev commented Feb 17, 2012

Will merge it this weekend. Sorry about delay on this.

@alexgorbatchev

This comment has been minimized.

Show comment
Hide comment
@alexgorbatchev

alexgorbatchev Feb 19, 2012

Owner

Thank you!

Owner

alexgorbatchev commented Feb 19, 2012

Thank you!

@alexgorbatchev

This comment has been minimized.

Show comment
Hide comment
@alexgorbatchev
Owner

alexgorbatchev commented Feb 19, 2012

Merged.

balupton added a commit to macropodhq/jquery-textext that referenced this issue Jul 24, 2012

Fixes #41, #53, #2, #28 - Suggestions aren't clickable when autocompl…
…ete is manually shown

Problem is that the click event does not fire for some reason, however
the mouseup event does. Likely browser lacking support, or the click
event is cancelled by a bubbling event. However, this fixes the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment