New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt plugin should read from `placeholder` attribute #8

Closed
alexgorbatchev opened this Issue Jan 13, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@alexgorbatchev
Owner

alexgorbatchev commented Jan 13, 2012

Is anyone interested in implementing this feature? It should be pretty straight forward. It should just check the attribute if option isn't provided.

@cmer

This comment has been minimized.

Show comment
Hide comment
@cmer

cmer Jan 16, 2012

Contributor

I fixed this and sent a pull request. Thanks for this awesome plugin!

Contributor

cmer commented Jan 16, 2012

I fixed this and sent a pull request. Thanks for this awesome plugin!

alexgorbatchev added a commit that referenced this issue Jan 17, 2012

Merge pull request #11 from cmer/master
Use textarea's placeholder attribute of prompt is not provided in options. Fixes issue #8.
@alexgorbatchev

This comment has been minimized.

Show comment
Hide comment
@alexgorbatchev

alexgorbatchev Jan 17, 2012

Owner

Merged, thanks!

Owner

alexgorbatchev commented Jan 17, 2012

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment