Missing licensing information #2

Closed
dpaleino opened this Issue Apr 14, 2012 · 7 comments

Comments

Projects
None yet
4 participants

Hello,

I'm packaging node-crc for Debian, and it's missing any licensing information. The only information is in the code, and refers to the various original pieces of software you took parts from.

Also, some parts of the code are taken from RFCs. Unfortunately, RFC documents aren't free for use, but are copyrighted by the IETF. Please have a look at RFC2223, section #11.

Thank you,
David

Owner

alexgorbatchev commented Apr 29, 2012

@dpaleino I didn't know about RFC copyright. I'm not sure what would be the proper license for this package in this case. Any suggestions?

@alexgorbatchev thanks for replying.

The best course of action would be implementing functions that generate, from scratch, the tables. An example of such code is at http://home.utah.edu/~nahaj/ada/crc/png_crc_table_generator.adb.html -- but that's in Ada, not Javascript. I also found a Python example, which might be more suitable to re-implement with Javascript: http://bytes.com/topic/python/answers/27677-crc-16-a .

lzap commented Sep 13, 2012

I'd love to see the licence in the git hub repo too ;-) There is existing python generator for those tables, can you use it to generate those? Its MIT licence, but the output is "yours".

http://www.tty1.net/pycrc/index_en.html

lzap commented Sep 13, 2012

Hmm I tried to generate and the output is totally different ;-) I am not a CRC expert, what is wrong with it?

 python pycrc.py --model crc-8 --algorithm table-driven --generate c -o crc.c

https://gist.github.com/3716721

Edit: I have tested my table with the following algorithm and it works:

https://gist.github.com/3716965

piscis commented Nov 19, 2012

Hi Alex,

I saw there has been an update a couple of day´s ago, is it possible to release this module under a proper license now (maybe MIT)?

Thanks,

Alex

Owner

alexgorbatchev commented Nov 19, 2012

@piscis I don't believe the license issue has been resolved

@wavded wavded pushed a commit to wavded/connect that referenced this issue Nov 1, 2013

@mdp mdp Replace 'node-crc' with 'buffer-crc32', fixes licensing
The 'crc' package is using code that is not freely licensed(MIT/BSD)
alexgorbatchev/node-crc#2

Express also moved to 'buffer-crc32' recently because of this issue.

Fixes senchalabs/connect#712
fe6ba40
Owner

alexgorbatchev commented Mar 25, 2014

License is now MIT based on full rewrite from another MIT Ruby module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment