Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it less likely to show duplicate answers #12

Merged
merged 2 commits into from May 11, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Contributor

commented Mar 25, 2017

Previously, we generated two incorrect answers for every question by sampling with replacement from the pool of all possible entities for some question. This means that we can display duplicate answers for a question in two scenarios: (1) we sample the same incorrect answer twice, or (2) one of the sampled incorrect answers is the same as the correct answer.

This commit adds some retry logic to the front-end that re-samples the incorrect answers if any of the two conditions above occurred. This does not eliminate the possibility of duplicate answers being displayed (e.g. consider the situation where we only have two candidate answers), but it should greatly reduce the impact to the user.

Fixes #5

c-w and others added some commits Mar 25, 2017

Make it less likely to show duplicate answers
Previously, we generated two incorrect answers for every question by
sampling with replacement from the pool of all possible entities for
some question. This means that we can display duplicate answers for a
question in two scenarios: (1) we sample the same incorrect answer
twice, or (2) one of the sampled incorrect answers is the same as the
correct answer.

This commit adds some retry logic to the front-end that re-samples the
incorrect answers if any of the two conditions above occurred. This does
not eliminate the possibility of duplicate answers being displayed (e.g.
consider the situation where we only have two candidate answers), but it
should greatly reduce the impact to the user.

Fixes #5

@alexgreene alexgreene merged commit e4c82ee into alexgreene:master May 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.