Replaced JSLint with ESLint.#41
Merged
Merged
Conversation
lightswitch05
force-pushed
the
feature/use-eslint
branch
3 times, most recently
from
July 30, 2016 17:13
aebef40 to
82b7ef6
Compare
lightswitch05
force-pushed
the
feature/use-eslint
branch
from
July 30, 2016 17:20
82b7ef6 to
2794529
Compare
Owner
|
Thanks for the PR, I will take a look. When I originally wrote the code, I used JSLint to force certain style I prefer. Since then ESLint has been evolving quickly, it's probably a good time to make this change. |
|
+1 on ESLint |
Contributor
Author
Owner
|
I will get to them soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm looking to make some contributions to this project, but I was unable to get JSLint 0.1.9 run on my computer. Looks like it is a common problem with macs and this old version (latest is 0.10.1). JSLint 0.2.0 and greater runs fine, but they changed the linting rules and do not have configuration options to get the project passing without major changes.
ESLint has many well documented configuration options. For this pull request I configured it to be at the strictest level without requiring too many changes. Most are just whitespace. Many options are stylelistic, and are therefore quite subjective. I tried my best to determine your prefered styles based on the existing code. Please let me know if you disagree with any of the rules and I will happily remove them.