Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced JSLint with ESLint. #41

Merged
merged 1 commit into from Aug 16, 2016

Conversation

@lightswitch05
Copy link
Contributor

lightswitch05 commented Jul 30, 2016

I'm looking to make some contributions to this project, but I was unable to get JSLint 0.1.9 run on my computer. Looks like it is a common problem with macs and this old version (latest is 0.10.1). JSLint 0.2.0 and greater runs fine, but they changed the linting rules and do not have configuration options to get the project passing without major changes.

ESLint has many well documented configuration options. For this pull request I configured it to be at the strictest level without requiring too many changes. Most are just whitespace. Many options are stylelistic, and are therefore quite subjective. I tried my best to determine your prefered styles based on the existing code. Please let me know if you disagree with any of the rules and I will happily remove them.

@lightswitch05 lightswitch05 force-pushed the lightswitch05:feature/use-eslint branch 3 times, most recently from aebef40 to 82b7ef6 Jul 30, 2016
@lightswitch05 lightswitch05 force-pushed the lightswitch05:feature/use-eslint branch from 82b7ef6 to 2794529 Jul 30, 2016
@alexguan

This comment has been minimized.

Copy link
Owner

alexguan commented Jul 31, 2016

Thanks for the PR, I will take a look. When I originally wrote the code, I used JSLint to force certain style I prefer. Since then ESLint has been evolving quickly, it's probably a good time to make this change.

@magicdawn

This comment has been minimized.

Copy link

magicdawn commented Aug 16, 2016

+1 on ESLint

@alexguan alexguan merged commit 9eeb2e7 into alexguan:master Aug 16, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lightswitch05

This comment has been minimized.

Copy link
Contributor Author

lightswitch05 commented Aug 17, 2016

Thanks for merging this! Any comments on #42 or #43?

@alexguan

This comment has been minimized.

Copy link
Owner

alexguan commented Aug 17, 2016

I will get to them soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.