Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved code coverage #43

Merged
merged 1 commit into from Feb 10, 2017

Conversation

@lightswitch05
Copy link
Contributor

lightswitch05 commented Jul 31, 2016

Improved code coverage:

Statements   : 100% ( 211/211 )
Branches     : 95.52% ( 64/67 )
Functions    : 100% ( 43/43 )
Lines        : 100% ( 211/211 )

I'm not sure how to get branch coverage up to 100%. As far as I can tell the or condition in this line is unreacheable:

Error.captureStackTrace(this, ctor || Exception);
@lightswitch05

This comment has been minimized.

Copy link
Contributor Author

lightswitch05 commented Feb 10, 2017

Since this is just a unit testing pull request, it wouldn't hurt to go ahead and merge it in so that future pull request could make use of the extra testing

@alexguan alexguan merged commit b462db5 into alexguan:master Feb 10, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.