Making the name of the S3 backup directory configurable #17

Merged
merged 6 commits into from Aug 11, 2013

Conversation

Projects
None yet
2 participants
Contributor

strayduy commented Aug 11, 2013

When the Mongo backups are uploaded to S3, they're stored under the "backups" directory in the configured S3 bucket (i.e. the path to each backup is BUCKET/backups/YYYY-MM-DD_hh-mm-ss.gz).

I updated the module to allow you to configure the name of the directory in S3, so you can set it to a value other than "backups."

The directory name is configurable through any of the following environment variables:

  • S3_BACKUP_DIR
  • S3_BACKUP_DIRNAME
  • S3_BACKUP_DIR_NAME

The MAX_BACKUPS setting will respect the configured directory name, so it will only remove backups that match the given directory prefix.

My use case is that I have a single S3 bucket with hourly, daily, and monthly backups, and I wanted the directory names to reflect which type of backup was in each directory. I also have a different MAX_BACKUPS value for each type of backup.

strayduy added some commits Jul 17, 2013

Fixing a bug with the Fog interface
The script was looking at all of the files in the specified bucket when determining which ones to delete. I only want it to look under the designated backup directory, so I added the directory prefix when it's considering which files to delete.
Owner

alexkravets commented Aug 11, 2013

Thanks a lot for this! Could you please add a passage to the README.md as well to keep documentation consistent, and add yourself to the end of the doc contributors section. Also bump gem version.

Thank you!

Contributor

strayduy commented Aug 11, 2013

Updated the README and incremented the gem version.

alexkravets pushed a commit that referenced this pull request Aug 11, 2013

Alexander Kravets
Merge pull request #17 from strayduy/configurable-s3-directory-name
Making the name of the S3 backup directory configurable

@alexkravets alexkravets merged commit ffc4d37 into alexkravets:master Aug 11, 2013

Owner

alexkravets commented Aug 11, 2013

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment