Alex Wolfe alexkwolfe

Alex Wolfe
  • Alex Wolfe cff994a
    The deregister function now deregisters an integration
Alex Wolfe

I think you want to keep this line, no? The operator should just be changed to -=, isn't that right?

Alex Wolfe

This test was meant to ensure that the age does not include the time on page. I'm looking at this on my phone so it's hard to be sure, but it appea…

Alex Wolfe

LGTM

Alex Wolfe
Alex Wolfe
Query integration should validate that a list_id and values are set
Alex Wolfe
  • Alex Wolfe e438d53
    New 'loan' and 'company' categories
Alex Wolfe

LGTM

Alex Wolfe
Alex Wolfe
Use is_masked instead of masked
1 commit with 3 additions and 3 deletions
Alex Wolfe

I'm not sure what the exact behavior will be if these fields co-exist. I'd need to investigate that before proceeding with a plan to transition fro…

Alex Wolfe

LGTM

Alex Wolfe

@cgrayson or @zalary, mind having a gander at this?

Alex Wolfe
Use is_masked instead of masked
1 commit with 3 additions and 3 deletions
Alex Wolfe
Alex Wolfe
Alex Wolfe
Added time_on_page_in_seconds to response variables
1 commit with 16 additions and 0 deletions
Alex Wolfe
Alex Wolfe

I was wondering that too. Whatever you think is best. ;) Longer term, the range type might need a "less than N" capability like is has a "more than…

Alex Wolfe

Oh right. And I see you have a conditional where this function is being called.

Alex Wolfe

I'm confused, I think. Line 164 and 210 claim that the integration appends annual_household_income not household_income. So I was just suggesting t…

Alex Wolfe

The range type supports a single number. I wonder if we ought to use those here. I'm worried about the fact that we're returning overlapping ranges.

Alex Wolfe

Consider using standard range strings in the description (i.e. 0-1, 1-2)

Alex Wolfe

I guess what I was saying is that query_household_income should be query_annual_household_income since the latter matches the actual datapoint retu…

Alex Wolfe

Missed some "k" and "m" characters in the descriptions.