Alex Wolfe alexkwolfe

@alexkwolfe

LGTM

@alexkwolfe
@alexkwolfe

Nice catch. I think we still want an error outcome, but the reason should be something like "Velocify is in maintenance mode".

@alexkwolfe

On second viewing it looks like the integration supports both. Can the deprecated ones be removed now? We'll need to check production flows where t…

@alexkwolfe
Stop using deprectated fields
@alexkwolfe

Looks like this happened because the query is set up to use phone_1 or phone_2 but this lead did not have either of those values. The correct behav…

@alexkwolfe

If so, then you could probably just put that statement on line 63 rather than declare a whole new function.

@alexkwolfe

Could this be simplified to the below? parseCorrected = (value) -> if value?.corrected? then value.email else null

@alexkwolfe

I don't understand. Why would the "corrected" field contain a value like "jhgjhg"? As a user, I expect that the "corrected" field would only contai…

@alexkwolfe

LGTM

@alexkwolfe

Also, you can just do this: return null unless value? ... That tests for null and undefined and is also more idiomatic in relation to the rest of t…

@alexkwolfe

I probably would have kept this. parseInt(undefined).toFixed(2) # => 'NaN' isNaN('NaN') # => true While it works, you're better off skipping the pa…

@alexkwolfe

I see. So the example you gave should be converted to "660.52"?

@alexkwolfe

WHA WHA! :balloon:

@alexkwolfe

Does the score come back as a decimal? Or is it just an integer?

@alexkwolfe
Make supported formats available for each type
@alexkwolfe

Mind rebasing this PR so that it's one commit?

@alexkwolfe

LGTM

@alexkwolfe

LGTM

@alexkwolfe

How is this different from the pixel integration?

@alexkwolfe

Capitalization in "Median level"

@alexkwolfe

Make a number type.

@alexkwolfe
@alexkwolfe

IMO, this would make more sense as a plural noun like address_error_codes.

@alexkwolfe
@alexkwolfe

I think that's mostly it. Make a GET request to a URL Follow redirects (?) Confirm that the response contains an image (?)

@alexkwolfe

I guess in order to reproduce it after this PR is merged, we'll have to just use an older version of the integration.

@alexkwolfe

Seems OK. I'd like to try to figure out what's wrong with the handler that it's not able to recover from an error in an integration though. Otherwi…

@alexkwolfe
Corrected email address should only have a corrected email address
@alexkwolfe

LGTM