Skip to content

Alex Wolfe
alexkwolfe

Jun 21, 2016
@alexkwolfe
Allow response content-type to be forced
Jun 17, 2016
@alexkwolfe

Can we merge this now so that we can get a passing build in the leadconduit-api task/remove-seeds branch?

Jun 8, 2016
@alexkwolfe
Form POST: HTTP 200 response with empty body is a failure
Jun 8, 2016
@alexkwolfe

LGTM

Jun 6, 2016
@alexkwolfe

LGTM

Jun 6, 2016
@alexkwolfe

I think we probably need to get rid of the functions in his module that rely on it being the authoritative source of standard fields. buildLeadVars

Jun 6, 2016
@alexkwolfe

LGTM. What do you think @cgrayson?

May 30, 2016
@alexkwolfe
May 30, 2016
@alexkwolfe
Update nodeUUID dependency
1 commit with 1 addition and 1 deletion
May 24, 2016
@alexkwolfe

Otherwise, LGTM 🐎

May 24, 2016
@alexkwolfe

This should be extra_parameter too, right?

May 24, 2016
@alexkwolfe

I feel like maybe we should replace "xml_parameter" with "XML Parameter", since users see the humanized version of the variable name.

May 24, 2016
@alexkwolfe

Should this be vars.extra_parameter?

May 23, 2016
@alexkwolfe

LGTM

May 20, 2016
@alexkwolfe

Other than that one comment, LGTM.

May 20, 2016
@alexkwolfe

This probably won't make any measurable difference given the array size, but tollFreeAreaCodes could be an object, for O(1) instead of O(n). tollFr…

alexkwolfe deleted branch html-attribute-reason at activeprospect/leadconduit-integration-custom
May 20, 2016
May 20, 2016
@alexkwolfe
  • @alexkwolfe 0f756c0
    Support for extracting reason from HTML attribute (#25)
May 20, 2016
@alexkwolfe
Support for extracting reason from HTML attribute
1 commit with 28 additions and 5 deletions
May 20, 2016
@alexkwolfe
Support for extracting reason from HTML attribute
1 commit with 28 additions and 5 deletions
May 20, 2016
@alexkwolfe
XML integrations: Join search docs
May 12, 2016
@alexkwolfe
Content-Length should be byte length, rather than string length
May 12, 2016
@alexkwolfe

LGTM

May 11, 2016
@alexkwolfe

Otherwise LGTM 🔥🎸🔥

May 11, 2016
@alexkwolfe

The 'Content-Type' header is only for HTTP requests that have a body. GET doesn't have a body, so this header can be excluded.

May 11, 2016
@alexkwolfe

Yes. This is an easy change. It just hasn't been made yet. Though, I don't think any of our customers will use SignalFX.

May 11, 2016
Something went wrong with that request. Please try again.