Skip to content

Pin gsl bottles to 2.7.1 on macOS to preserve 10.15/Catalina on x86 and 11.0/Big Sur compatibility + update cibuildwheels#212

Merged
alexlancaster merged 18 commits intomainfrom
brew_gsl
Jul 17, 2024
Merged

Pin gsl bottles to 2.7.1 on macOS to preserve 10.15/Catalina on x86 and 11.0/Big Sur compatibility + update cibuildwheels#212
alexlancaster merged 18 commits intomainfrom
brew_gsl

Conversation

@alexlancaster
Copy link
Owner

@alexlancaster alexlancaster commented Jul 9, 2024

With the latest release of gsl of 2.8 on brew for MacOS, support for binary releases of gsl for versions of MacOS < 12 was dropped. This means that all CI builds currently fail on all MacOS systems.

In order to continue to support a minimum of 10.15 (Catalina) and later on x86, or 11.0 (Big Sur) and later on arm64, we would need to build gsl during the cibuildwheel process. This would create a lot of maintenance overhead, and since Apple was EOLed Monterey and earlier, this PR creates wheels that will only install on MacOS 12 (Monterey) and later versions.

@sjmack : are you OK with making our minimum MacOS version be MacOS 12.0 (aka "Monterey")?

@alexlancaster alexlancaster added the bug Something isn't working, should not be used for new features: use "enhancement" for those label Jul 9, 2024
@alexlancaster alexlancaster self-assigned this Jul 9, 2024
@alexlancaster alexlancaster changed the title Bump minimum of MacOS builds to MacOS 12 / Monterey Bump minimum macOS target to macOS 12 / Monterey Jul 10, 2024
@alexlancaster alexlancaster changed the title Bump minimum macOS target to macOS 12 / Monterey Pin gsl bottles to 2.7.1 on macOS to preserve 10.15/Catalina on x86 and 11.0/Big Sur compatibility Jul 16, 2024
@alexlancaster
Copy link
Owner Author

In order to continue to support a minimum of 10.15 (Catalina) and later on x86, or 11.0 (Big Sur) and later on arm64, we would need to build gsl during the cibuildwheel process. This would create a lot of maintenance overhead, and since Apple was EOLed Monterey and earlier, this PR creates wheels that will only install on MacOS 12 (Monterey) and later versions.

@sjmack : are you OK with making our minimum MacOS version be MacOS 12.0 (aka "Monterey")?

@sjmack: I managed to find a workaround that preserves 10.15 (x86) / 11.0 (arm64) compatibility for the time being by installing archived bottles of gsl 2.7.1 from brew. We may have to revisit this in the future to keep pace with gsl releases.

@sjmack
Copy link
Collaborator

sjmack commented Jul 16, 2024

Sorry. I didn't realize I was tagged in these messages; I can't tell in the emails from the headers.

I'm okay with excluding everything under MacOS 12. I think don't think it is unreasonable.

@alexlancaster
Copy link
Owner Author

Sorry. I didn't realize I was tagged in these messages; I can't tell in the emails from the headers.

I'm okay with excluding everything under MacOS 12. I think don't think it is unreasonable.

I found a workaround for the moment, so it keeps the status quo. It also preserves Python 3.6 and 3.7 support. I'll merge this PR.

@alexlancaster alexlancaster merged commit 4410962 into main Jul 17, 2024
@alexlancaster alexlancaster deleted the brew_gsl branch July 17, 2024 01:03
@alexlancaster alexlancaster changed the title Pin gsl bottles to 2.7.1 on macOS to preserve 10.15/Catalina on x86 and 11.0/Big Sur compatibility Pin gsl bottles to 2.7.1 on macOS to preserve 10.15/Catalina on x86 and 11.0/Big Sur compatibility + update cibuildwheels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, should not be used for new features: use "enhancement" for those

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants