protocol is not having the desired effect #39

Closed
danielb2 opened this Issue Aug 6, 2013 · 5 comments

3 participants

@danielb2

url_options: { host: "example.com", protocol: 'https' }

I wanted the urls generated to have:

<loc>https://example.com/...</loc>

However, it still shows http.

Bug?

@danielb2

Documentation mentions protocol but I don't see it anywhere in the code. Looks like the http is hardcoded too.

https://github.com/alexrabarts/big_sitemap/blob/master/lib/big_sitemap.rb#L54

@rngtng
Collaborator

use url_options: { host: "example.com", scheme: 'https' } and it should work. the hardcoded value is the default one .merge(..) overwrites it..

@danielb2

You're right, so it does.

OK, so I'll leave this open to update the documentation to read scheme instead of protocol.

@danielb2

And thanks 👍

@alexrabarts
Owner

Thank you. The documentation is now fixed.

@alexrabarts alexrabarts closed this Aug 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment