always add geocoder to Rack::Request if defined #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I don't think that including in both with cause an issue. |
aceunreal
pushed a commit
to aceunreal/geocoder
that referenced
this pull request
Sep 28, 2016
ChangsoonKim
pushed a commit
to ChangsoonKim/geocoder
that referenced
this pull request
Nov 23, 2017
zacviandier
pushed a commit
to teezily/geocoder
that referenced
this pull request
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since the code change in #1061, if a Rack application loads both Rails and Sinatra simultaneously (e.g., both are included in the same middleware stack for handling different routes), then only
ActionDispatch::Requestwill be enhanced with geocoder methods and notRack::Request, causingrequest#locationto be undefined in the Sinatra route. (My use-case is currently Rails 4.2, but presumably affects Rails 5 as well.)The fix in this PR changes the
if ... elsifconditional to instead use two separate conditionals.