This sets up the sqlite vs non-sqlite paths at setup time, rather than run time, which should have performance benefits. #267

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

Empact commented Jul 25, 2012

The tests run green but I wouldn't consider it well-veted just yet. I still need to run it against apps running & not running sqlite. Perhaps you can give that a go?

This sets up the sqlite vs non-sqlite paths at setup time, rather tha…
…n run time, which should have performance benefits. The tests run green but I wouldn't consider it well-veted just yet.
Owner

alexreisner commented Dec 8, 2012

Really sorry for the incredibly slow response. I'd love to merge this, but master has changed so much since you submitted that it needs to be rewritten. If you can rewrite, I will merge, promptly.

Owner

alexreisner commented Apr 20, 2013

This is good work and should be merged, not only for the performance benefits but for the improved code structure. Unfortunately the changes required are significant. If somebody wants to update and submit a new pull request I'd be thrilled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment