5.18 fixes #1

Merged
merged 2 commits into from May 25, 2013

3 participants

@trinitum

Module doesn't compile on perl 5.18 because of outdated Devel::CheckLib. Also it fails tests because POD encoding is not specified. These two commits fix the problems.

@dkg
Collaborator
@alexrj alexrj merged commit 135142a into alexrj:master May 25, 2013
@alexrj
Owner

Thank you @trinitum. Version 1.26 is on its way to CPAN. I forgot to write your name in the Changelog before releasing, but I'm doing it now so it will be in for next one. Sorry.

@dkg, nice to hear you again. It's been long time since our latest work on Crypt::GCrypt.

BTW, compilation on my OS X emits some warnings:

/usr/bin/gcc-4.2 -c   -funsigned-char -pipe -O2 -arch x86_64 -fno-common -DPERL_DARWIN -I/opt/local/include -no-cpp-precomp -fno-strict-aliasing -fstack-protector -I/opt/local/include -O3   -DVERSION=\"1.26\" -DXS_VERSION=\"1.26\"  "-I/opt/local/lib/perl5/5.12.3/darwin-multi-2level/CORE"   GCrypt.c
In file included from GCrypt.xs:17:
ppport.h:227:1: warning: "PERL_UNUSED_DECL" redefined
In file included from GCrypt.xs:14:
/opt/local/lib/perl5/5.12.3/darwin-multi-2level/CORE/perl.h:308:1: warning: this is the location of the previous definition
GCrypt.xs: In function ‘find_padding’:
GCrypt.xs:93: warning: cast from pointer to integer of different size
GCrypt.xs:93: warning: cast from pointer to integer of different size
GCrypt.xs:103: warning: cast from pointer to integer of different size
GCrypt.xs:103: warning: cast from pointer to integer of different size
GCrypt.xs: In function ‘XS_Crypt__GCrypt_new’:
GCrypt.xs:337: warning: ‘gcry_ac_name_to_id’ is deprecated (declared at /opt/local/include/gcrypt.h:1613)

I decided to release quickly anyway because compatibility with 5.18 is more urgent.

@dkg
Collaborator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment