Problem with ExtrusionLoop (commit c37ef2f ?) #2028

Closed
ledvinap opened this Issue May 12, 2014 · 5 comments

Projects

None yet

3 participants

@ledvinap
Collaborator

Commit c37ef2f probably introduced few problems.

at https://github.com/alexrj/Slic3r/blob/master/lib/Slic3r/GCode.pm#L220, role is not property of $loop, so slicer fail with if --randomize-start is enabled.

with --no-randomize-start, extrude_loop could be called with empty ExtrusionLoop (about 8-th call with test-squares.stl), failing nearest point lookup on https://github.com/alexrj/Slic3r/blob/master/lib/Slic3r/GCode.pm#L226 :

terminate called after throwing an instance of 'std::out_of_range'
  what():  vector::_M_range_check
Aborted

After testing for empty ExtrusionLoop, it generates gcode, but perimeters on second layer are missing.

Files here: https://drive.google.com/folderview?id=0B9HM4UOKDQBLYWZNcWRFa3ZscG8&usp=sharing

@alexrj
Owner
alexrj commented May 12, 2014

Good, thank you: more unit tests are needed.

@alexrj
Owner
alexrj commented May 12, 2014

Second bug is caused by the known Clipper bug about open paths with coincident endpoints. Our workaround is not catching some cases...

@alexrj alexrj added a commit that referenced this issue May 12, 2014
@alexrj No tests were covering randomize-start, which was not working anymore…
… after recent ExtrusionLoop refactoring. #2028
69002b8
@alexrj
Owner
alexrj commented May 12, 2014

Actually, it looks like a distinct Clipper bug. I isolated it into a couple failing test cases and reported it to upstream maintainer: http://sourceforge.net/p/polyclipping/bugs/96/

@alexrj alexrj closed this in 3df2488 May 23, 2014
@alexrj alexrj added a commit that referenced this issue May 25, 2014
@alexrj Revert "Updated Clipper to r467 but it doesn't seem to fix #2028 yet"
This reverts commit a62457d.
0decbbf
@alexrj
Owner
alexrj commented May 26, 2014

This is now fixed in Clipper.

@alexrj alexrj added a commit that referenced this issue May 26, 2014
@alexrj Update Clipper to r468. #2028 6a64395
@alexrj alexrj added a commit that referenced this issue May 26, 2014
@alexrj Revert "Update Clipper to r468. #2028"
This reverts commit 6a64395.
2ac40f9
@bmbeverst

Can confirm this occurs on Lubuntu 14.04.01 with latest git version. Reverting to version 1.1.7 fixes the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment