1.2.2-dev: Error in function split at src/libslic3r/TriangleMesh.cpp:253: split() requires repair() #2398

Closed
lordofhyphens opened this Issue Dec 4, 2014 · 11 comments

Projects

None yet

3 participants

@lordofhyphens
Collaborator

Getting a crash when trying to split a STL generated by OpenSCAD.
SCAD file: http://www.thingiverse.com/thing:18379
Problematic STL: http://www.2shared.com/file/e7_mH1Ox/jonaskuehling_gregs-wade-v3-no.html

Error in function split at src/libslic3r/TriangleMesh.cpp:253: split() requires repair()
at /home/lenox/slic3r-upstream/lib/Slic3r/GUI/Plater.pm line 782.
Slic3r::GUI::Plater::split_object(Slic3r::GUI::Plater=HASH(0x35892f0)) called at /home/lenox/slic3r-upstream/lib/Slic3r/GUI/Plater.pm line 218
Slic3r::GUI::Plater::ANON(Slic3r::GUI::Plater=HASH(0x35892f0), Wx::CommandEvent=SCALAR(0x372cff0)) called at /home/lenox/slic3r-upstream/slic3r.pl line 105
eval {...} called at /home/lenox/slic3r-upstream/slic3r.pl line 105

@alexrj
Owner
alexrj commented Dec 7, 2014

Uhm, I can't reproduce this on current HEAD. Do you have an up-to-date checkout?
What steps to reproduce it?

@alexrj alexrj added this to the 1.2.2 milestone Dec 7, 2014
@lordofhyphens
Collaborator

I can't seem to reproduce that exact crash, but trying split that file crashes Slic3r with a segfault on current HEAD. No other errors reported.

@a4jp-com
a4jp-com commented Dec 8, 2014

Lordofhyphens, when I compiled Slic3r using "perl Build.PL -v" I saw the line for t/slice.t was "skipped: temporarily disabled". Are you slicing to split files? How are you splitting the files in Slic3r?

@lordofhyphens
Collaborator

There's a split button for multipart stls.
On Dec 7, 2014 6:19 PM, "a4jp-com" notifications@github.com wrote:

Lordofhyphens, when I compiled Slic3r using "perl Build.PL -v" I saw the
line for t/slice.t was "skipped: temporarily disabled". Are you slicing to
split files? How are you splitting the files in Slic3r?


Reply to this email directly or view it on GitHub
#2398 (comment).

@lordofhyphens
Collaborator

As I can't get this issue to reproduce locally anymore, suspect it was just some weirdness on my end.

@alexrj
Owner
alexrj commented Dec 26, 2014

Or maybe I fixed it as part of another issue... reopen if you find it again :)

@lordofhyphens
Collaborator

Wasn't sure that I was able to repro with the same commit anymore. I'll be
sure to reopen if I see it again.
On Dec 26, 2014 10:45 AM, "Alessandro Ranellucci" notifications@github.com
wrote:

Or maybe I fixed it as part of another issue... reopen if you find it
again :)


Reply to this email directly or view it on GitHub
#2398 (comment).

@lordofhyphens
Collaborator

Well, got it to break again when trying to split an AMF file.

Error in function split at src/libslic3r/TriangleMesh.cpp:253: split() requires repair()
at /home/lenox/slic3r-upstream/lib/Slic3r/GUI/Plater.pm line 801.
Slic3r::GUI::Plater::split_object(Slic3r::GUI::Plater=HASH(0x4822bb8)) called at /home/lenox/slic3r-upstream/lib/Slic3r/GUI/Plater.pm line 1488
Slic3r::GUI::Plater::ANON(Slic3r::GUI::MainFrame=HASH(0x4822858), Wx::CommandEvent=SCALAR(0x5746500)) called at /home/lenox/slic3r-upstream/lib/Slic3r/GUI/Plater.pm line 86
eval {...} called at /home/lenox/slic3r-upstream/lib/Slic3r/GUI/Plater.pm line 86
Slic3r::GUI::Plater::ANON(Slic3r::GUI::Plater::2D=HASH(0x484ecc8), Wx::Point=SCALAR(0x5730048)) called at /home/lenox/slic3r-upstream/lib/Slic3r/GUI/Plater.pm line 108
Slic3r::GUI::Plater::ANON(Wx::Point=SCALAR(0x5730048)) called at /home/lenox/slic3r-upstream/lib/Slic3r/GUI/Plater/2D.pm line 195
Slic3r::GUI::Plater::2D::mouse_event(Slic3r::GUI::Plater::2D=HASH(0x484ecc8), Wx::MouseEvent=SCALAR(0x7325488)) called at /home/lenox/slic3r-upstream/slic3r.pl line 105
eval {...} called at /home/lenox/slic3r-upstream/slic3r.pl line 105

@lordofhyphens lordofhyphens reopened this Dec 27, 2014
@alexrj alexrj modified the milestone: 1.2.3, 1.2.2, 1.2.4 Dec 28, 2014
@alexrj alexrj added a commit that referenced this issue Dec 30, 2014
@alexrj Bugfix: early object destruction caused a segfault when splitting. Al…
…so fixed a memory leak and restore background processing when split only detected one part. #2466 #2398
c4832c5
@alexrj
Owner
alexrj commented Dec 30, 2014

Okay, this should fixed now. Can you test? Thank you!

@lordofhyphens
Collaborator

No crash. Ran into a separate issue re: split being very aggressive in how it splits (and I think a little inconsistent), but that's going into a new issue when I have a testcase together.

@alexrj
Owner
alexrj commented Dec 30, 2014

Okay, thank you!

@alexrj alexrj closed this Dec 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment