Incorrect concave seam point detection when inside loops #2857

Closed
xoan opened this Issue May 26, 2015 · 1 comment

Projects

None yet

2 participants

@xoan
xoan commented May 26, 2015

When there is one convex point in an inside closed loop (a hole), it is choosed as the perimeter start point instead one of the other concave ones (outside concave points are detected and used)

cube-convex-inside

config.ini: https://gist.github.com/xoan/7b3c230fdda1e4fc2a2f (it is also reproducible with de defaultconfig)

OpenJSCAD compatible code to generate the STL:

//!OpenSCAD
difference() {
    cube([20,20,10], center = true);
    translate([10,10]) cube([10,10,20], center = true);
    difference() {
        cube([10,10,20], center = true);
        translate([5,5]) cube([10,10,20], center = true);
    }
}
@xoan xoan changed the title from [1.2.7-experimental] Incorrect concave seam point detection when inside loops to Incorrect concave seam point detection when inside loops May 26, 2015
@alexrj alexrj added this to the 1.2.8 milestone Jun 1, 2015
@alexrj alexrj added a commit that referenced this issue Jun 1, 2015
@alexrj Bugfix: concave starting points were not correctly detected for slice…
… holes. Includes regression test. #2857
f14c0e2
@alexrj
Owner
alexrj commented Jun 1, 2015

Good catch. I fixed this and added a regression test.

@alexrj alexrj closed this Jun 1, 2015
@alexrj alexrj added the Fixed label Jun 1, 2015
@born2b born2b added a commit to born2b/Slic3r that referenced this issue Jun 10, 2015
@alexrj @born2b + born2b Bugfix: concave starting points were not correctly detected for slice…
… holes. Includes regression test. #2857
d3b98fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment