Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fix XS build on Windows #1433 #1681 #1745

Merged
merged 1 commit into from Feb 7, 2014

Conversation

Projects
None yet
2 participants
Contributor

kelow commented Feb 1, 2014

Hi Alex! I've been having issues as in #1433 and #1681. I've reordered some includes and it compiles fine on Windows7 both 32bit and 64bit. I hope it doesn't mess with any other builds as I don't have any Linux/MacOS to test it right now.

Owner

alexrj commented Feb 7, 2014

Hi! That's really good news, thank you for fixing that issue!

However I don't understand what the issue was and how do your changes actually fix it. Can you explain it me? I'd like to avoid reintroducing the issue by mistake in the future.

@alexrj alexrj added a commit that referenced this pull request Feb 7, 2014

@alexrj alexrj Merge pull request #1745 from kelow/master
fix XS build on Windows #1433 #1681
56ff776

@alexrj alexrj merged commit 56ff776 into alexrj:master Feb 7, 2014

1 check passed

default The Travis CI build passed
Details
Contributor

kelow commented Feb 8, 2014

No problem.
Frankly speaking it's a magic for me. I was always told to include my own headers after all compiler (I mean sstream for example) ones. After a few years of coding in C/C++ I still don't know why but it fixes most of my problems with "undeclared blah blah" and so on when compiling under Windows. The same project seems unaffected when compiled with GCC under Linux.
So for me the old rule is still true but seems to be important only with GCC on Windows now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment