Fix for #3655 - always print after gcode send #3659

merged 1 commit into from Jan 11, 2017


None yet

4 participants

gege2b commented Jan 9, 2017

No description provided.

@@ -1399,7 +1399,7 @@ sub send_gcode {
# OctoPrint doesn't like Windows paths so we use basename()
# Also, since we need to read from filesystem we process it through encode_path()
file => [ $path, basename($path) ],
- print => $self->{send_gcode_file} ? 1 : 0,
+ print => $self->{send_gcode_file_print} ? 1 : 0,
lordofhyphens Jan 10, 2017 Collaborator

Basically a typo?

gege2b Jan 10, 2017 edited Contributor

basically, yeah :)

As mentionned, it's a really tiny fix but I'm pretty proud of it ahaha

lordofhyphens Jan 11, 2017 Collaborator

Yeah, I said you should put it in so your name is in the commit log for it ;)

I would have merged it in myself if I'd had time to test it locally.

alexrj commented Jan 11, 2017

Great job! :-)))))))))

@alexrj alexrj merged commit 8838763 into alexrj:master Jan 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

Does this make the "send to printer" button always send & print? Because that would break my workflow.

gege2b commented Jan 16, 2017 edited

no, it just make the confirmation box act as intended

I did a feature request in #3657 to make the "send & print" feature really optionnal (just a checkbox and no confirmation dialog)
Still waiting for comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment