Skip to content

Iterables.assertContainsExactly should not throw ex. if 'actual' and 'values' are empty #124

Open
mkarneim opened this Issue Nov 13, 2012 · 5 comments

4 participants

@mkarneim

org.fest.assertions.internal.Iterables.assertContainsExactly(AssertionInfo info, Iterable<?> actual, Object[] values)

calls checkIsNotNullAndNotEmpty(values) and throws an IllegalArgumentException with message "The array of values to look for should not be empty" EVEN if values AND actual are empty.

But I would expect that it returns successfully.

  • Michael

(PS: Thanks for this great tool!)

@joel-costigliola
Collaborator

I agree, accepting empty values makes sense.

Thanks for reporting this, we will fix it in the 2.0 version.

@alexruiz alexruiz was assigned Jan 10, 2013
@alexruiz
Owner

Great suggestion! Thanks Michael. The next milestone will fix this.

@mkarneim

Nice, thank you.

@aaschmid
aaschmid commented Apr 3, 2013

same for org.fest.assertions.internal.Maps.assertContains ...

... and probably some more assertion methods.

@joel-costigliola
Collaborator

For your information, this issue has been fixed in AssertJ a fork of Fest Assert 2.0M10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.