containsExactly() throws ArrayIndexOutOfBoundsException (2.0M8) #138

Open
wjtk opened this Issue Jan 16, 2013 · 3 comments

Comments

Projects
None yet
2 participants

wjtk commented Jan 16, 2013

For code:

List<String> z = new ArrayList<>(Arrays.asList("a","a","a"));       
assertThat(z).containsExactly("a","a");

Stacktrace:

java.lang.ArrayIndexOutOfBoundsException: 2
    at org.fest.assertions.internal.Iterables.assertContainsExactly(Iterables.java:995)
    at org.fest.assertions.api.AbstractIterableAssert.containsExactly(AbstractIterableAssert.java:99)

Regards, Wojtek

Contributor

joel-costigliola commented Jan 16, 2013

Definitely a bug ! Thanks for reporting this.

Having said that, this assertion javadoc is misleading ... What we wanted to do with containsExactly is to assert that the actual Iterable contained all the given objects in the same order, it entails that the actual size must match the varargs size.

It means your assertion will fail (but not with an exception !), as described below :

// should fail because z has 3 elements 
assertThat(z).containsExactly("a","a");

// succeeds as given varargs is composed of 3 elements matching exactly z elements 
assertThat(z).containsExactly("a","a", "a");

You probably know that but you can use containsOnly to test z content only :

assertThat(z).containsOnly("a");

wjtk commented Jan 16, 2013

I know and understand :-)
Element values were not important, it could be a,b,c. I choose only "a" accidentally.

Contributor

joel-costigliola commented Feb 24, 2013

fixed in 2.0M9 branch.
I'm not closing this issue because it must be merged in master branch where a major rework for 2.0 is being done, merge will happen after the rework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment