Skip to content

Commit 56b825a

Browse files
committed
Fix bug in DB Summary function
1 parent 124ed09 commit 56b825a

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

riemann/in_memory_database.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ func (imdb InMemoryDivisorDb) Summarize() SummaryStats {
3232
if rds.N > largest_computed_n.N {
3333
largest_computed_n = rds
3434
}
35-
if int(rds.WitnessValue) > int(largest_witness_value.WitnessValue) {
35+
if rds.WitnessValue > largest_witness_value.WitnessValue {
3636
largest_witness_value = rds
3737
}
3838
}

riemann/in_memory_database_test.go

+19
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,25 @@ var _ = Describe("In Memory Database Tests", func() {
8989
}
9090
Expect(summaryData).To(Equal(expectedSummaryData))
9191
})
92+
93+
})
94+
95+
FIt("Summarizes for float values", func() {
96+
var db = riemann.DivisorDb(riemann.InMemoryDivisorDb{Data: make(map[int64]riemann.RiemannDivisorSum)})
97+
98+
By("correctly summarizing non-empty data", func() {
99+
records := []riemann.RiemannDivisorSum{
100+
{N: 10092, DivisorSum: 24388, WitnessValue: 1.088},
101+
{N: 10080, DivisorSum: 39000, WitnessValue: 1.788},
102+
}
103+
db.Upsert(records)
104+
summaryData := db.Summarize()
105+
expectedSummaryData := riemann.SummaryStats{
106+
LargestWitnessValue: riemann.RiemannDivisorSum{N: 10080, DivisorSum: 39000, WitnessValue: 1.788},
107+
LargestComputedN: riemann.RiemannDivisorSum{N: 10092, DivisorSum: 24388, WitnessValue: 1.088},
108+
}
109+
Expect(summaryData).To(Equal(expectedSummaryData))
110+
})
92111
})
93112

94113
})

0 commit comments

Comments
 (0)