Added additional tests and covered all parts of code (including panics)

riemann/counterexample_search_test.go

@@ -28,6 +28,10 @@ var _ = Describe("CounterExample Search", func() {
 		Expect(err).To(HaveOccurred())
 	})
 
+	It("should panic if asked to find witnesses for cases where DivisorSum cannot be found", func() {
+		Expect(func() { riemann.WitnessValue(-1, -1) }).To(PanicWith("Error calculating DivisorSum"))
+	})
+
 	It("should search successfully", func() {
 		output, err := riemann.Search(10000, 5040)
 		if err != nil {
@@ -59,4 +63,9 @@ var _ = Describe("CounterExample Search", func() {
 		}
 
 	})
+
+	It("Should panic if it can't compute riemann sums", func() {
+		Expect(func() { riemann.ComputerRiemannDivisorSums(0, 1) }).Should(PanicWith("Divisor Sum cannot be found"))
+
+	})
 })

riemann/populate_database.go

@@ -2,19 +2,23 @@ package riemann
 
 import "fmt"
 
-func PopulateDB(db DivisorDb, startingN, endingN, batchSize int64) {
+func FindStartingNForDB(db DivisorDb, startingN int64) int64 {
 	var currentStartingN int64
 
 	dbStartingN := db.Summarize().LargestComputedN.N
 
 	if dbStartingN > startingN {
-		currentStartingN = dbStartingN
+		currentStartingN = dbStartingN + 1
 	} else {
 		currentStartingN = startingN
 	}
+	return currentStartingN
+}
+
+func PopulateDB(db DivisorDb, startingN, endingN, batchSize int64) {
+	currentStartingN := FindStartingNForDB(db, startingN)
 	currentEndingN := currentStartingN + batchSize
 
-	fmt.Println(dbStartingN, startingN, endingN, currentEndingN, currentStartingN)
 	for endingN == -1 || currentEndingN < endingN+batchSize {
 		db.Upsert(ComputerRiemannDivisorSums(currentStartingN, currentEndingN))
 		fmt.Printf("Computed Sums from %d to %d\n", currentStartingN, currentEndingN)

riemann/populate_database_test.go

@@ -9,10 +9,19 @@ import (
 
 var _ = Describe("Populates Database correctly", func() {
 
+	var db = riemann.DivisorDb(riemann.InMemoryDivisorDb{Data: make(map[int64]riemann.RiemannDivisorSum)})
 	It("Populates and Summarizes correctly", func() {
-		var db = riemann.DivisorDb(riemann.InMemoryDivisorDb{Data: make(map[int64]riemann.RiemannDivisorSum)})
+
 		riemann.PopulateDB(db, 10070, 10085, 21)
 		summaryData := db.Summarize()
-		Expect(summaryData.LargestWitnessValue.N).To(Equal(int64(10080)))
+		Expect(summaryData.LargestWitnessValue.N).To(BeEquivalentTo(10080))
+		Expect(summaryData.LargestComputedN.N).To(BeEquivalentTo(10091))
+	})
+
+	It("Finds startingN correctly", func() {
+
+		startingN := riemann.FindStartingNForDB(db, 10075)
+		Expect(startingN).To(BeEquivalentTo(10092))
+
 	})
 })