New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SearchHits.FetchResults second parameter (end vs count) #18

Merged
merged 1 commit into from May 4, 2013

Conversation

Projects
None yet
2 participants
@ambrauer

ambrauer commented Mar 1, 2013

When retrieving paged search results, any page other than the first and last will return more items than it should.

For example, a search resulting in 50 items, page size 10 would go like this:
Page 1 (start=0, end=10) => items 1-10 (ok)
Page 2 (start=10, end=20) => items 10-30 (wrong)
Page 3 (start=20, end=30) => items 20-50 (wrong)
Page 4 (start=30, end=40) => items 30-50 (wrong)
Page 5 (start=40, end=50) => items 40-50 (ok)

alexshyba added a commit that referenced this pull request May 4, 2013

Merge pull request #18 from ambrauer/master
Fix SearchHits.FetchResults second parameter (end vs count)

@alexshyba alexshyba merged commit 7c7e416 into alexshyba:master May 4, 2013

@alexshyba

This comment has been minimized.

Show comment
Hide comment
@alexshyba

alexshyba May 4, 2013

Owner

thank you, @ambrauer.

Owner

alexshyba commented May 4, 2013

thank you, @ambrauer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment