Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Causes Colony Manager to designate un-collectible diagonal tiles for mining. #18

Open
CodeOptimist opened this issue Jan 24, 2020 · 1 comment

Comments

@CodeOptimist
Copy link

@CodeOptimist CodeOptimist commented Jan 24, 2020

First of all - absolutely worship your mods.

So feel free to close this as not-a-bug. Took me a while to actually track this down, chatting with Fluffy tonight: https://www.twitch.tv/videos/541126699
I just learned that mining diagonally is actually a settable option of your mod - that's awesome.

Basically the issue I was encountering is Fluffy's Colony Manager has a mining quota, and with your mod, designates diagonal tiles to be mined. But although they can be mined the resource can't actually be collected diagonally - only orthogonally. So the mining quota is never actually met.

But now I know I can just turn this feature off.
Thanks for an amazing mod. 👍

@CodeOptimist CodeOptimist changed the title Causes Colony Manager to designate un-mineable diagonal tiles for mining. Causes Colony Manager to designate un-collectible diagonal tiles for mining. Jan 24, 2020
@alextd

This comment has been minimized.

Copy link
Owner

@alextd alextd commented Jan 25, 2020

So everything would be fine to collect that walled-off resource, but somewhere along the way IsGoodStoreCell checks if the storage DESTINATION is reachable from the ITEM, not from the CARRIER. Replace stuff allows the CARRIER to grab the ITEM, but then the game thinks the ITEM can't reach the DESTINATION. Of course the item can't go anywhere because it's walled off, but the carrier could.

I am recalling an occasional problem that building a room in a mountain would leave a corner wall unbuilt because the rock chunk left behind blocked building. This is the same basic problem.

So that would be an easy change, check path from carrier, not from item - but that's also changing a deep call that lots of hauling code uses. Something to look into later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.