New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate availabilities with short service duration and unavailabilities ignorance. #236

Closed
absolutejam opened this Issue Nov 8, 2016 · 9 comments

Comments

Projects
None yet
2 participants
@absolutejam
Copy link

absolutejam commented Nov 8, 2016

One of my users is experiencing a weird bug - They have all the time windows in the day presenting to the user multiple times in the front end. As well as this, these time windows are ignoring the 'Unavailable' periods.

image

And nothing looks awry in MySQL:
image

When I check the back-end, her calendar looks perfectly normal

  • An 'unavailable' window that I have added for all providers that blocks out everything except appointments on the 17th,
  • Manual 'unavailable' windows that the user has added.
  • Successfully registered appointments by users.
@absolutejam

This comment has been minimized.

Copy link
Author

absolutejam commented Nov 8, 2016

Tried removing some of the duplicate 'unavailable' slots but the issue persists.

@alextselegidis

This comment has been minimized.

Copy link
Owner

alextselegidis commented Nov 8, 2016

Hmm, just being curious but how's that you have appointments that do not have a customer or service IDs?

@absolutejam

This comment has been minimized.

Copy link
Author

absolutejam commented Nov 9, 2016

They're 'unavailable' slots? Or are they still missing data? Which IDs do you mean?

@alextselegidis

This comment has been minimized.

Copy link
Owner

alextselegidis commented Nov 9, 2016

I mean the NULL values for the hash, id_users_customersand id_services columns in your database screenshot.

@absolutejam

This comment has been minimized.

Copy link
Author

absolutejam commented Nov 9, 2016

Erm, I dunno haha. The top two were manually inserted via a SQL statement for all my providers but the others weren't. I can perhaps check another user to see if they have the same NULL values? I just assumed that I unavailable = 1 then the others would be NULL

@alextselegidis

This comment has been minimized.

Copy link
Owner

alextselegidis commented Nov 9, 2016

Could you please make a backup of your database, remove the records that have the NULL values and then try again. I want to make sure that this is not a data integrity issue :)

@alextselegidis

This comment has been minimized.

Copy link
Owner

alextselegidis commented Nov 9, 2016

Oh sorry, I just saw that unavailable entries (or google synced events) can accept NULL values in these fields, so this won't be a problem. Could you please send me your installation URL with a PM (alextselegidis@gmail.com).

@alextselegidis alextselegidis added the bug label Nov 13, 2016

@alextselegidis alextselegidis added this to the v1.2.1 milestone Nov 13, 2016

@alextselegidis alextselegidis self-assigned this Nov 13, 2016

@alextselegidis alextselegidis changed the title [BUG] Duplicate time windows and ignoring unavailable Duplicate availabilities with short service duration and unavailabilities ignorance. Nov 13, 2016

@absolutejam

This comment has been minimized.

Copy link
Author

absolutejam commented Nov 14, 2016

Just letting you know that it seems to occur to all of the providers once they hit a threshold of a certain amount of bookings (I'm not sure how many) as the staff with a few bookings it hasn't occurred to, but it is now affecting everyone once they get a few bookings on the system.

If you need access to the box, I can give you it.

@alextselegidis

This comment has been minimized.

Copy link
Owner

alextselegidis commented Nov 14, 2016

Yeah, it seems that there is a bug in the availabilities calculation. Access to the box would be great in order to examine the issue internally.

Thanks for reporting ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment